Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

open an issue automatically when a PR is merged on google/transit #1080

Closed
isabelle-dr opened this issue Dec 20, 2021 · 8 comments
Closed

open an issue automatically when a PR is merged on google/transit #1080

isabelle-dr opened this issue Dec 20, 2021 · 8 comments
Assignees
Labels
enhancement New feature request or improvement on an existing feature status: Ready An issue that is ready to be worked on. workflow Related to Github Actions, triggers, and boards.

Comments

@isabelle-dr
Copy link
Contributor

isabelle-dr commented Dec 20, 2021

In order to keep the validator up to date with the changes, we need to review PR's merged on the official specification to see if we need to modify a rule in the Canonical GTFS Schedule Validator.
Having an automatic issue would help to make sure we don't miss anything.

Additional context in:

@isabelle-dr isabelle-dr added enhancement New feature request or improvement on an existing feature and removed enhancement New feature request or improvement on an existing feature labels Dec 20, 2021
@isabelle-dr isabelle-dr added this to the v3.1 milestone Jan 9, 2022
@isabelle-dr isabelle-dr added the enhancement New feature request or improvement on an existing feature label Jan 21, 2022
@isabelle-dr isabelle-dr added the status: Ready An issue that is ready to be worked on. label Oct 3, 2022
@isabelle-dr isabelle-dr removed this from the v3.2.0 - custom validation milestone Oct 3, 2022
@davidgamez
Copy link
Member

There is an interesting thread here: https://github.com/orgs/community/discussions/26323
One of the replies mentioned a GitHub app that we might be able to use, https://github.com/marketplace/webhook-actions

@isabelle-dr
Copy link
Contributor Author

The logic would be: if REFERENCE.md is modified, we open an issue.
https://github.com/google/transit/blob/master/gtfs/spec/en/reference.md

@isabelle-dr isabelle-dr added this to the Now milestone Jun 12, 2023
@emmambd emmambd added the workflow Related to Github Actions, triggers, and boards. label Jul 10, 2023
@jcpitre jcpitre self-assigned this Aug 14, 2023
@emmambd emmambd assigned fredericsimard and unassigned jcpitre Aug 14, 2023
@emmambd
Copy link
Contributor

emmambd commented Sep 11, 2023

Implemented! Waiting for next merge on reference.md to google/transit to test. It's on me to check this and mark this "done". Will likely take a few months for the next spec vote. cc @jcpitre @fredericsimard

@isabelle-dr
Copy link
Contributor Author

Guessing it didn't work?

@fredericsimard
Copy link
Contributor

Guessing it didn't work?

@isabelle-dr No, it did. Here's an example: #1601

@emmambd
Copy link
Contributor

emmambd commented Nov 21, 2023

@fredericsimard @isabelle-dr Finally confirmed success from #1601, so closing now.

@emmambd emmambd closed this as completed Nov 21, 2023
@emmambd
Copy link
Contributor

emmambd commented Nov 25, 2023

@fredericsimard Reopening for one more request with this: can we automatically add the "needs triage" label to any issue that comes from this workflow?

@fredericsimard
Copy link
Contributor

@fredericsimard Reopening for one more request with this: can we automatically add the "needs triage" label to any issue that comes from this workflow?

Certainly. See here: #1610

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature request or improvement on an existing feature status: Ready An issue that is ready to be worked on. workflow Related to Github Actions, triggers, and boards.
Projects
None yet
Development

No branches or pull requests

5 participants