Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web Validator hangs after supplying non-zip URL #1445

Closed
evansiroky opened this issue May 23, 2023 · 3 comments · Fixed by #1481
Closed

Web Validator hangs after supplying non-zip URL #1445

evansiroky opened this issue May 23, 2023 · 3 comments · Fixed by #1481
Assignees
Labels
bug Something isn't working (crash, a rule has a problem) python Pull requests that update Python code status: Ready An issue that is ready to be worked on.

Comments

@evansiroky
Copy link

Describe the bug

Potentially related to #1440, if a URL to a non-zip file is provided, the web validator will hang and not be able to proceed.

Steps/Code to Reproduce

  1. Open web validator
  2. Enter http://www.google.com as the URL
  3. Press the validate button

Expected Results

There should be an error that says that the URL does not appear to contain a zip file.

Actual Results

Web app hangs.

Screenshots

Screen Recording 2023-05-23 at 11 37 58 AM

Files used

none

Validator version

latest

Operating system

Web

Java version

No response

Additional notes

No response

@evansiroky evansiroky added bug Something isn't working (crash, a rule has a problem) status: Needs triage Applied to all new issues labels May 23, 2023
@Rossellaross87polito
Copy link

Rossellaross87polito commented May 25, 2023

hello i have uploaded a zip file and the report of the validator is:
GTFS Schedule Validation Report
104789 notices reported (0 errors, 104783 warnings, 6 infos)
This validation report was generated using the Canonical GTFS Schedule validator.

Use this report alongside the rules page to get more details about the validation issues.

there is a problem in the plug in.
Could you help me?
gtfs_compressed.zip

@isabelle-dr
Copy link
Contributor

@Rossellaross87polito is the problem that the report wasn't rendering properly / not at all?
If this is the case, it's probably because the report contains too many notices.
We limited the number of records to appear on the report in #1433 which was merged last week. Can you try again?

@isabelle-dr
Copy link
Contributor

@evansiroky thank you for opening this.
We will have a look at it this week.

@cka-y cka-y self-assigned this Jun 2, 2023
@isabelle-dr isabelle-dr added status: Ready An issue that is ready to be worked on. python Pull requests that update Python code and removed status: Needs triage Applied to all new issues labels Jun 2, 2023
@cka-y cka-y linked a pull request Jun 5, 2023 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working (crash, a rule has a problem) python Pull requests that update Python code status: Ready An issue that is ready to be worked on.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants