Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow not creating the "super" git repository #49

Open
Holt59 opened this issue Jul 25, 2020 · 2 comments
Open

Allow not creating the "super" git repository #49

Holt59 opened this issue Jul 25, 2020 · 2 comments

Comments

@Holt59
Copy link
Member

Holt59 commented Jul 25, 2020

The "super" git repository is kind of huge with all the submodules, and is not updated (as far as I can tell) when doing a simple mob build super so when using git-enhanced command line such as posh-git, doing anything in modorganizer_super is very slow since the command line as to be updated each time.

Feature: Add an option (maybe under super task) to not create the "main" repository.

On a side note, the following repository are not added as submodules currently, this might be a bug?

Untracked files:
  (use "git add <file>..." to include in what will be committed)

        fnistool/
        form43_checker/
        installer/
        preview_dds/
        tool_configurator/
@isanae
Copy link
Contributor

isanae commented Jul 25, 2020

and is not updated (as far as I can tell) when doing a simple mob build super

Everything should be updated and pulled every time unless no_pull is set for it.

Add an option (maybe under super task) to not create the "main" repository.

If I understand correctly, mob -d prefix -s super:task/enabled=false build should do that, no? You can also set enabled=false in [super:task] in an ini. But I'm not sure I understand what you're asking for.

the following repository are not added as submodules currently

I see all of them in modorganizer_super/.git/config, except for installer. Can you check what you have in there? For installer, it's a different task type than all the others (it's not a cmake+msbuild) and so doesn't have the code to add the submodule. I'll fix it.

@Holt59
Copy link
Member Author

Holt59 commented Jul 26, 2020

I am really talking about the local git repository that contains all the submodules, not the repositories containing the project. Basically, I would like an option to not have modorganizer_super\.git (modorganizer_super would be a simple directory).

Everything should be updated and pulled every time unless no_pull is set for it.

The projects are updated, but the submodules are not staged in the main repositories, so you end up with this kind of output:

❯ git status
On branch master

No commits yet

Changes to be committed:
  (use "git rm --cached <file>..." to unstage)

        new file:   .gitmodules
        new file:   archive
        new file:   bsa_extractor
        new file:   bsapacker
        new file:   bsatk
        new file:   check_fnis
        new file:   cmake_common
        new file:   diagnose_basic
        new file:   esptk
        new file:   game_enderal
        new file:   game_fallout3
        new file:   game_fallout4
        new file:   game_fallout4vr
        new file:   game_falloutnv
        new file:   game_features
        ...

Changes not staged for commit:
  (use "git add <file>..." to update what will be committed)
  (use "git checkout -- <file>..." to discard changes in working directory)
  (commit or discard the untracked or modified content in submodules)

        modified:   archive (untracked content)
        modified:   bsatk (untracked content)
        modified:   esptk (untracked content)
        modified:   game_features (untracked content)
        modified:   game_gamebryo (untracked content)
        ...

Untracked files:
  (use "git add <file>..." to include in what will be committed)

        fnistool/
        form43_checker/
        installer/
        installer_omod/
        preview_dds/
        tool_configurator/

I personally don't mind having the changes never commited in the main local repository, but it's just makes e.g., posh-git, very slow.

I see all of them in modorganizer_super/.git/config, except for installer. Can you check what you have in there? For installer, it's a different task type than all the others (it's not a cmake+msbuild) and so doesn't have the code to add the submodule. I'll fix it.

I definitively do not have the one untracked above in .git\config.

If I understand correctly, mob -d prefix -s super:task/enabled=false build should do that, no? You can also set enabled=false in [super:task] in an ini. But I'm not sure I understand what you're asking for.

Doesn't this simply disable everything under modorganizer_super? I tried deleting modorganizer_super\.git and modorganizer_super\.gitmodules and then running:

mob -s super:task/enabled=false build modorganizer

And the local repository was re-created, so I don't think that solves the problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants