-
Notifications
You must be signed in to change notification settings - Fork 198
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge language zh-CN and zh-Hans #250
Comments
This is the reason. Hey @Samuel12321, How about also switching zh-Hant to zh-TW? Would that reduce confusing? |
Well, zh-Hant has two main sebsets: zh-HK and zh-TW, and they are kind of different in word usage, so...would be better if we add another zh-HK translation. |
So zh-TW and zh-HK instead of zh-Hant (traditional) and zk-CN instead of zh-Hans (simplified)? Is that ok? |
Yes, I think this would be the best solution. |
Hey @FrzMtrsprt, Does the system default option actually pick up your system language? We got some complaints that it didn't work for Chinese. |
It's working perfectly, except for the menu item "Personalization" is not being translated...Will that be fixed in the next release? |
which version are you using, that bug was fixed a while ago. |
I installed it from Microsoft Store. In System Settings it says 0.8.1.0, but in the app it says 0.8.0.1, could it be a wrong package was uploaded? |
no, that was just a mistake on my part. When we released 0.8.1 i changed the package version number but forgot to change the version number displayed in the app.😁
On second thoughts, that may have been part of the 0.8.2 release. Please wait for that to be available. |
My only concern is that everyone else seems to be moving away from ZH-CN, ZH-TW .... to just zh-HANS and ZH-HANT to simplify things. Are we managing locale correctly? |
Or else we could do some workarounds within the code. We could remap zh-CN (system) to zh-Hans (app) and zh-TW (system) to zh-Hant (app) when applying the language. |
There's three zh-Hans (Simplified) in the world: zh-CN (China Mainland), zh-SG (Singapore) and zh-MY (Malaysia) By default the Chinese system recognizes the region (CN, TW), not the variant (Hant, Hans). What's more is that usually Malaysia, Singapore and Macau users won't contribute for their own language. The further decision is up to developers then. |
in my opinion, merging zh-CN and zh-Hans is okay, and it will be better for Chinese Simplified users, because at present, selecting between zh-CN or zh-Hans DO makes confusions. (even though they are exactly the same) But, for zh-Hant, it is different. so we have to make some change for zh-Hant to match the usage(?) in both Hong Kong and Taiwan. remapping the language files is also a great idea. (especially for zh-MO, zh-SG and zh-MY) 鉴于 issue 主是中国用户 我觉得合并 zh-Hans 和 zh-CN 其实是个好主意,毕竟当前版本的软件,选择语言的列表有两个代表简体中文的语言包,会让人犯选择困难症。(虽然这俩都一样) 至于 zh-Hant 就需要针对香港和台湾地区的用语习惯做出一些微调。 当然重定向(?)语言文件也是个好主意,尤其对于 zh-MO、zh-SG、zh-MY 来说。 |
So, what's the conclusion people? Should we
What should we do? |
I think use zh-CN + zh-TW is the best solution as zh-CN/zh-TW can not represent for the zh-Hans/zh-Hant, and our translation is optimized for zh-CN/zh-TW, not the whole Chinese |
So only zh-CN and zh-TW and no other regional Chinese langs? @Samuel12321, what do you say? |
My vote would be on remapping everything to just zh-Hans and zh-Hant. |
I agree.
Nah mate. I know nothing about localisation. |
FYI.
So if you are writing Chinese Simplified and using mainland Chinese wording, the full language code is Sorry for the complexity, but usually |
Thanks for confusing me further! Very cool 👍 |
I think the best way is remapping, though. |
Same, since we don't have a zh-HK translator for now. |
@ShankarBUS which release do you want this in? |
Yes |
? |
I just discovered another problem. I had a look at one of Microsoft's project called WinUI. It uses I guess we must stay in line with their approach. I mean they are a multi-billion-dollar company and they don't use I'm legit confused and blanked out. People here recommend to use Most .NET based apps and libraries uses |
I must thank you all for giving me ideas and suggestions regarding this problem. Let's wait till Kinnara/ModernWpf#202 is finalized. |
Have changed it to just zh-CN and zh-TW to stay inline with winui. Happy to change this again if anyone comes up with a better idea. |
As zh-Hans (Simplified Chinese) and zh-CN (Chinese used in Mainland China) is basically the same varient of Chinese language, there's no need to keep both, or it may cause confusion to Chinese users.
They should be merged into one single language translation file. I suggest that zh-Hans should be deleted and zh-CN should be kept untouched.
The text was updated successfully, but these errors were encountered: