Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggested Fix: Replace the event "keyup" with "keydown" for Compatibility with Chinese IMEs #276

Open
chennien opened this issue Aug 9, 2024 · 0 comments

Comments

@chennien
Copy link

chennien commented Aug 9, 2024

When typing with a Chinese input method editor (IME) on a computer, users select characters using the arrow keys and the enter key. However, in the AlertifyJS prompt window, pressing enter to select a character triggers the form submission. This causes significant inconvenience for users, as shown in the video.

I subsequently replaced all instances of the “keyup” event in the JS file with “keydown,” which perfectly resolved the issue without affecting usability. This modified version has already been deployed to the website “Hearty Journal”. Therefore, I suggest that the author consider making this adjustment as well.

AlertifyJS_keyup_issue_20240808.mp4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant