-
-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
img2img works #16
Comments
@barepixels Good points, discussions enabled. As for your question - both modes you described make sense (single image, and cycling over different images when more of them is available), but currently all images generated with img2img are using first image from the gallery as an input (so you can see different variants of it, generated using different seeds). |
@barepixels I've just implemented cyclic over input images as the default behaviour for img2img (available on moonride-main). So for example if you have image A, and image B as inputs, and batch size 4, then you will get 2 variants of image A, and 2 variants of image B. And if you would like to have 4 variants of image A, then you simply load only image A as the source image. Let me know if it works for you. |
Loading more than one images (A & B) works Not sure if I will ever load more than 1 because I want to focus on 1 task at a time. What I would like to see is to have the original uploaded image "A" in the gallery. This will serve 2 purpose a) easy to compare before and after |
@barepixels That could complicate UI, and I'd like to keep initial view as simple as possible - I will need to think a bit about how those function could be added to the UI, without making it cluttered. |
Maybe I have not said it clearly. Let me try to illustrate it with Photoshop. Hang on |
This is what I am asking for This will serve 2 purpose a) easy to compare before and after This does not affect the existing elegant interface. No extra button or tab |
@barepixels Okay, that makes sense - I will try to figure out something like this. |
Thank you. |
@barepixels I have initial idea for for the layout (and initial buggy implementation - it's currently messed up when preview is displayed, etc.) - I'd like to use two tabs for separate inputs and outputs galleries, it would look like that: |
that would work. plus the preview will be bigger :-) |
@barepixels Implemented, available on moonride-main :). |
Excellent my friend. I can compare let's say #3 vs the original just by clicking on the two tabs back and forth. :-) Not exactly sure how the Output to Input feature works. I assume:
Can you confirm this is correct? |
@barepixels Selection doesn't matter. If you have 1 image loaded as input, then it will use it for every generated output. If you will load 2, then it will cycle over these 2. So with imported images A and B, and batch size 8 you would get 4 variants of A, and 4 variants of B. If you loaded just A - you would get 8 variants of A. You can also put inputs of completely different resolutions and aspect ratios - it will automatically upscale (or downscale) input image to roughly 1 megapixel each. And if you didn't set any input, but generated already something to Output - it will automatically import that for further processing :). Default img2img settings allow it to change input image quite a lot, and use it mostly as a rough guidence - if you want to verify how it works and see similarity between images more clearly, then you can lower Denoise (in Advanced tab) to let's say 0.7 or 0.8 - it will preserve much more from the input images, then. |
Here is a potential problem I might have (I think)
As for Denoise (in Advanced tab), default minimum is at 0.5? What if I want 0.2 |
@barepixels For now in situations like that simplest solution would be simply using "Load Image(s)", and picking those you want from the output folder. I guess it would be nice to be able to send selected to the input gallery, but I am not sure how to proceed about that - I will need to take a deeper look into Gradio and Gallery in there, to see if and how it could be done. Theoretically you could use very low denoise like that, but it wouldn't change input much - but if you find it useful / needed, then sure - I'll change it. |
Thank you for changing default Denoise. The "simplest solution would be simply using "Load Image(s)", and picking those you want from the output folder." Agree, this is good enough. Sometimes too much is bad I think you should stop/drop working on the "Output to Input" and focus on other modifications... such as Abort button. haha I tried to just reload the browser hoping to abort the queue but it didn't work ... because there was no signal to tell Fooocus to stop. I felt stupid. haha |
Next thing worth doing would be probably preparing easy to use (like download + click on .bat) package for the less experienced users. But both this and aborting the processing (also worth implementing - I agree on that) are separate issues / discussions, so let's stop it here. I consider img2img in current state as good enough for typical use cases, so I am closing this one :). |
Just starting to play with img2img and am so happy. Thank you
So far I only played with 2 sliders from the Advanced tab "Img2img Start Step" and "Img2img Denoise"
Also I want to as if you should make a "discussions" area on GitHub similar to what lllyasviel did here https://github.com/lllyasviel/Fooocus/discussions
I feel the "Issues" area should reserve for bug report.
The text was updated successfully, but these errors were encountered: