Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

migrating to jQuery 1.9.x #586

Closed
thezoggy opened this issue Apr 22, 2014 · 4 comments
Closed

migrating to jQuery 1.9.x #586

thezoggy opened this issue Apr 22, 2014 · 4 comments

Comments

@thezoggy
Copy link
Collaborator

upgrading a project to newer jquery version, going through local code and libs to see what we need to address before making the switch..

https://github.com/jquery/jquery-migrate/blob/master/warnings.md

.parseJSON -- https://github.com/jquery/jquery-migrate/blob/master/warnings.md#jqmigrate-jqueryparsejson-requires-a-valid-json-string

jquery.tablesorter.widgets.js - I parseJSON being used here which may need the || "null" to make it work the same across all jquery versions?

and
https://github.com/Mottie/tablesorter/blob/master/js/widgets/widget-build-table.js#L35 ?

@Mottie
Copy link
Owner

Mottie commented Apr 22, 2014

Hey @thezoggy!

Are you having issues with it? I tried changing that line to d = $.parseJSON(d || null); and I'm still seeing the warning....

@thezoggy
Copy link
Collaborator Author

I havent tested with jquery 1.9.x without the migrate plugin yet to really know if its an issue (i dont use json input with tablesorter on this project.. i do use parseJSON input for ajax notifications.. why i ran across it... and thought about ts)

@Mottie
Copy link
Owner

Mottie commented Jun 18, 2014

I'm guessing this issue has been resolved, so I'm going to close it. If you continue to have problems, please feel free to continue this discussion.

@Mottie Mottie closed this as completed Jun 18, 2014
@thezoggy thezoggy reopened this Jun 19, 2014
@Mottie
Copy link
Owner

Mottie commented Jan 18, 2015

Hey zoggy!

Now that I look back at my first comment, I didn't have the null wrapped in quotes; but I guess it doesn't matter.

Anyway, I was just testing the storage and build widgets with migrate plugin v1.2.1 and I don't see any warnings now. I'll go ahead and make these changes, just-in-case. Sorry for taking so long to fix this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants