Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove wagtail-modeltranslation inheritance #7891

Closed
Pomax opened this issue Nov 18, 2021 · 3 comments
Closed

remove wagtail-modeltranslation inheritance #7891

Pomax opened this issue Nov 18, 2021 · 3 comments
Labels
code cleanup engineering good first bug maintain Maintain digital systems p2 this works should get done when all p1 have been resolved wagtail wagtail related issues

Comments

@Pomax
Copy link
Contributor

Pomax commented Nov 18, 2021

We have some code with content_panels = Page.content_panels # Needed for wagtail-modeltranslation to work and we should verify whether we still need that (I suspect we do =D) or whether we can remove this everywhere now that we're using wagtail-localize

┆Issue is synchronized with this Jira Task

@tbrlpld
Copy link
Collaborator

tbrlpld commented Mar 30, 2022

@Pomax I could use some clarification on what is necessary here and why we would want to remove it.

Is this talking about page models? If so, using content_panels = Page.content_panel + [...other panel types] is used to extend the default list of content panels (I think this only really contains the FieldPanel for title) with the ones specific this the given page model. This is a fairly common practice not only used for translation. (E.g. see this section in the Wagtail tutorial).

@tbrlpld tbrlpld added the maintain Maintain digital systems label Apr 11, 2022
@tbrlpld tbrlpld removed their assignment Aug 11, 2022
@mtdenton
Copy link
Contributor

mtdenton commented Dec 7, 2023

Timebox to 1 hour

@simont-cr simont-cr added wagtail wagtail related issues p2 this works should get done when all p1 have been resolved labels Feb 22, 2024
@data-sync-user
Copy link
Collaborator

➤ diego commented:

Hi Simon Acosta Torres

Reviewing the description of this ticket and also the thread of the issue on github, I see that there’s a confusion or a lack of context regarding the request or consideration of content_panels removal. Because as Tibor @tbrlpld correctly higlights, content_panels are used to extend the model and also these editor panels defined how the filds will be arranged in the page editor interface. So this removal is not necessary.

I also add the link to Wagtail documentation where this is specified:

https://docs.wagtail.org/en/stable/topics/pages.html#editor-panels ( https://docs.wagtail.org/en/stable/topics/pages.html#editor-panels|smart-link )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code cleanup engineering good first bug maintain Maintain digital systems p2 this works should get done when all p1 have been resolved wagtail wagtail related issues
Projects
None yet
Development

No branches or pull requests

5 participants