Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

All external links should open in a new tab #8214

Open
danielfmiranda opened this issue Feb 9, 2022 · 2 comments
Open

All external links should open in a new tab #8214

danielfmiranda opened this issue Feb 9, 2022 · 2 comments
Labels
backend engineering feature request frontend p3 wagtail wagtail related issues

Comments

@danielfmiranda
Copy link
Collaborator

danielfmiranda commented Feb 9, 2022 •
edited by data-sync-user
Loading

We have added "target='_blank'" to any external links within a rich text block in #8195

However, since external links in other blocks such as link buttons and video/image captions still open themselves in the same tab vs a new one like the rich-text external links, it is providing an inconsistent user experience.

The ask of this ticket is to make sure that any external link on the site opens in a new tab.

┆Issue is synchronized with this Jira Task
@danielfmiranda danielfmiranda mentioned this issue Feb 9, 2022
Merged
@simont-cr
Copy link
Collaborator

@danielfmiranda Is this still something that needs to be corrected in the platform and if so, would you say we could just keep it with a P3 status?

@simont-cr simont-cr added cleanup-confirmation Label to keep track of issues that need additional confirmation in order to close. wagtail wagtail related issues labels Feb 22, 2024
@danielfmiranda danielfmiranda added p3 and removed cleanup-confirmation Label to keep track of issues that need additional confirmation in order to close. labels Mar 7, 2024
@danielfmiranda
Copy link
Collaborator Author

Hi @simont-cr I would say yes and that this can keep the P3 status. I have updated the labels to reflect this 👍

@ramram-mf ramram-mf mentioned this issue Oct 9, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
backend engineering feature request frontend p3 wagtail wagtail related issues
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@danielfmiranda @simont-cr