-
Notifications
You must be signed in to change notification settings - Fork 153
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
7787 - drag to scroll on desktop #7900
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The functionality to drag to scroll across subcategories are working for me across browsers and viewports, thanks Simon!
more cleanup
When testing on https://foundation-s-7787-drag-vpxuans.herokuapp.com/en/privacynotincluded/categories/smart-thermostats-smoke-detectors/ It looks like this works once (I can click and drag to move the subcats around) but after a mouse release/mouse up it stops working. |
it seems to not always work though, sometimes on a page load nothing seems to happen (other than text-selecting) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
marking as "request changes" for now based on the events not reliably firing
It looks like the highlighted subcategory doesn't quite make it into view all the time, but if @sabrinang's okay with it we can land this first, then fix that in a follow-up issue. |
@nancyt1 could you have a look and see if more work is required (although not necessarily as part of this PR itself)? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drag to scroll works for me across viewports and selected subcategories snapped into viewport when clicked for me. I think it looks good!
(Not sure if it's just the review app but drag to scroll doesn't work after I refresh the page, only when I first land on it)
Closes #7787
Test URL: https://foundation-s-7787-drag-vpxuans.herokuapp.com/en/privacynotincluded/categories/smart-home/