[7884] remove unnecessary admin fields from mozfest homepage #8130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TheoChevalier
requested changes
Jan 21, 2022
There was a problem hiding this comment.
Hey @richbrennan, just a heads up that the changes need to be replicated to the translatable_fields variable below.
Thanks!
Thanks for spotting Theo! I've updated the |
Pomax
reviewed
Jan 24, 2022
|
And a happy new year to you, too! |
Pomax
approved these changes
Jan 24, 2022
TheoChevalier
approved these changes
Jan 25, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @Pomax , happy new year! :-)
Closes #7883
Specifies the admin fields on the mozfest homepage content panels, as per Marc's list: #7883 (comment)
I didn't attempt to re-implement the dynamic
content_panelsgeneration from https://github.com/mozilla/foundation.mozilla.org/pull/7884/files because it was dependant on a hard-coded value, so doesn't need conditional logic, but correct me if I'm wrong :-)Link to sample test page: https://foundation-s-7883-mozfe-ivs7ow.herokuapp.com/cms/pages/161/edit/