Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GtkFileChooserNative support, new js properties and other improvements to Waterfox Classic #1164

Merged
merged 132 commits into from
Oct 1, 2019

Conversation

hawkeye116477
Copy link
Contributor

@hawkeye116477 hawkeye116477 commented Sep 19, 2019

Borrowed from https://github.com/MoonchildProductions/UXP/commit/47c48dfcb87a574f6b96f3abf3ed14b9b08b2371.
This adds support for native KDE dialog.
But to make it really working, users needs to have xdg-desktop-portal-kde package and run Waterfox with GTK_USE_DIALOG=1.
That package is available from Ubuntu 18 and Debian 10. But on GTK lower than 3.24.4 can be some problems (Ubuntu 18), so in that case SUSE's solution which I use on my package still will be better (even it works on Ubuntu 16 and Debian 9).

@grahamperrin
Copy link

grahamperrin commented Sep 19, 2019

Thanks!

https://lists.freebsd.org/pipermail/freebsd-current/2019-September/074405.html

https://lists.freebsd.org/pipermail/freebsd-current/2019-September/074442.html

… dbus portal …

wolfbeast and others added 28 commits September 20, 2019 10:10
This renames our internal function names because *Left and *Right might
be deprecated and have to be removed later, making that trivial.
From ICU 57, ICU supports emoji presentation as draft API.
…jfkthame

- Segoe UI Emoji for Windows 8+
- Twemoji Mozilla for Windows 7
- Apple Color Emoji for OSX
- Twemoji Mozilla for GTK(Linux). fontconfig doesn't support emoji as family name.
- Noto Color Emoji for Android
Fix nsAtom->nsIAtom and FindAndAddFamilies()
This resolves some issues with building on mingw.

Thanks to Tom Ritter for help developing this patch.

MozReview-Commit-ID: BmJ5TbQAq17
Upstream is using a different syntax, which isn't as nice,
but using the same format makes comparison easier.

Also expect yasm for mingw.

MozReview-Commit-ID: 8PvmyB45AOu
…inetik

aom_dsp_rtcd_defs.pl checks only whether this key is present
in the config, not whether it is set to true or not. Our script
sets CONFIG_FOO=no for disabled options, while the upstream
build system omits them, resulting in extra symbol declarations
the build will never define.

Work around this by stripping the offending disabled config key
if it is disabled.

MozReview-Commit-ID: IyVDO2G3s3L
As far as I can tell, nothing uses the DISABLE_AVX define
when generating the rtcd headers.

MozReview-Commit-ID: Cc5tufOKP63
Add a --repo switch to `mach vendor aom` to allow specifying
an alternate repository url.

Update our vendor script to support commit query and
snapshot download from github as well as upstream's
gitiles instance.

This lets us work with experimental branches for testing.

Also cleans up some naming and checks the passed url for
one of the two supported sites. We could fall back to
doing a complete clone and query the local repository,
but this covers most use cases.
Vendor upstream commit id f5bdeac22930ff4c6b219be49c843db35970b918
to pick up changes since the last import.
Recent changes made this a public header, so it needs to be
available to callers like AOMDecoder.

MozReview-Commit-ID: KKXcv8bdVYj
Backport upstream patch by Sebastian Alaiwan fixing
aom_peek_stream_info after changes to the superblock
location.

BUG=aomedia:681

Change-Id: Iefce035d633d1533c8400d85b3257971757160bc
MozReview-Commit-ID: 7QEnDrpVFkC
The libaom av1 decoder can return high bit depth frame
data now. Handle those frames by downsampling them
to 8 bits per channel so they can be passed to our
normal playback pipeline.

MozReview-Commit-ID: 97XYeh3YvQw
The libaom av1 decoder will return 16 bit per channel
aom_image_t structures with only 8 significant bits.

Detect this case and use the mSkip fields of PlanarYCbCrImage
to handle the extra data instead of allocating and performing
an extra copy to obtain the necessary 8 bit representation.

MozReview-Commit-ID: 8H9YZe86Qzu
We've been recording the commit id from the last vendor in
README_MOZILLA inside the various media directories. Since
we now support a --repo switch to pull from forks, record
this info as well, to make it easier to find contiguous
upstream source.

MozReview-Commit-ID: 1RanpkWfAeC
Visual Studio 2015u3 fails to compile reconintra.c for win32
debug targets. It's confused by the #if conditional inside
the assert macro expansion. Nathan Froyd tells me this is
undefined bahaviour.

The checks are obsolete upstream. Address the issue by
duplicating the assert calls for each branch of the
conditional.

MozReview-Commit-ID: GSjGsa11xfJ
This is a practice commit to clarify what arguments we're accepting.

MozReview-Commit-ID: 2qQbNAYzGwr
Adding partial support for 10/12-bit video images seems to have
broken the native pixel-stride support we were using to pass
8-bit AV1 frame data formatted in 16-bit pixel values, resulting
in vertical green lines.

Revert to the earlier behaviour of always downsampling to 8 bit data.
This is slower for the demo stream, but at least displays correctly.

MozReview-Commit-ID: 8kSd9kph9DE
Update to upstream commit id e87fb2378f01103d5d6e477a4ef6892dc714e614
from a couple of weeks ago to pick up changes.

MozReview-Commit-ID: H7H69A7qFXD
This uses the cmakeparser to generate sources.mozbuild and the
config files for each platform.

MozReview-Commit-ID: CU6oIPJXtTw
…mshal

By default, run_process() eats the output of the child process, which means when it fails we get an exception about the return code, but none of the error messages the script printed, with makes the cause of failure opaque.

Resolve this by passing a log_name parameter, which will cause the default line_handler to pass all lines of output to the local logging instance, by default at the INFO level.
Check for filenames which differ only by .asm vs .c filename
extensions when importing a new version of the libaom reference
implementation of the av1 video codec.

These confuse our build system as well. Also remove the obsolete
vp8 and vp9 search directories, which generate warnings from 'find'.

MozReview-Commit-ID: DRZL7GUrsYh
Alfredo.Yang and others added 13 commits September 27, 2019 13:43
MozReview-Commit-ID: E1zhXdLEPFS
…r function which could be able to return error. r=kinetik

MozReview-Commit-ID: 5LJVCTYIT7o
Since MDSM won't treat EOS as an erorr now, so we could revert bug1359058 p2.

MozReview-Commit-ID: JqkIrOiBu8v
…lculation. r=kikuo

Invalid samples with empty content won't ever be demuxed. As such they can't participate in buffered range calculations.

MozReview-Commit-ID: 9LPhyKKMSyM
… log when parsing fails. r=kinetik

MozReview-Commit-ID: Bo6q3ysvktr
…t the shape of the resulting object right. r=jandem

MozReview-Commit-ID: 8wnOnUv57pV
…llects the union of the state bits for a range of tracks (idempotent change). r=dholbert

MozReview-Commit-ID: HzSxwPMkBEu
…ne track with an 'auto' min sizing function for Automatic Minimum Size to apply. r=dholbert
…an async opacity animation. r=birtles,mattwoodrow
MozReview-Commit-ID: 38ZdC9udcH1
@hawkeye116477
Copy link
Contributor Author

hawkeye116477 commented Sep 28, 2019

I added some mp4 crash fixes and fix for mediamarkt.de (https://www.reddit.com/r/waterfox/comments/c38byn/page_layout_problem/) now.

@grahamperrin
Copy link

☝ thumbs up for sheer effort! (I haven't tested, but don't doubt the goodness of all of this …)

@hawkeye116477
Copy link
Contributor Author

hawkeye116477 commented Sep 29, 2019

Now added fix for #1066 and https://www.reddit.com/r/waterfox/comments/d62qit/mlbcom_banner_rendering_issues/.

@MrAlex94 Do I need to do something to green light this 😄? And don't worry, I left Nintendo's site for you (Shadow DOM v1) and maybe https://bugzilla.mozilla.org/show_bug.cgi?id=1392177.

Updated: Added fix for #1004 also.

hawkeye116477 and others added 4 commits September 29, 2019 10:01
… system group. r=masayuki

The focus event listener in editor is system group, so synthesizeKey and/or synthesizeMouse doesn't work on focus event since editor doesn't initialize selection yet. So use setTimeout to work synthesizeKey and etc well.
@MrAlex94
Copy link
Collaborator

MrAlex94 commented Oct 1, 2019

@MrAlex94 Do I need to do something to green light this 😄? And don't worry, I left Nintendo's site for you (Shadow DOM v1) and maybe https://bugzilla.mozilla.org/show_bug.cgi?id=1392177.

Not at all! Just testing the features that have been affected by the changes on all the platforms, just in case there's a breakage somewhere. Has happened to me so many times before when I merge changes from upstream, trying to be a bit careful this time so I don't ruin things for everyone 😅. Sorry it's taking so long, literally testing as we speak, VMs are slow!

@hawkeye116477
Copy link
Contributor Author

hawkeye116477 commented Oct 1, 2019

Ok, all in all right, if you're in a hurry, the devil is happy.

@MrAlex94 MrAlex94 merged commit d5f113c into BrowserWorks:master Oct 1, 2019
@MrAlex94
Copy link
Collaborator

MrAlex94 commented Oct 1, 2019

Excellent job! All worked perfectly.

hawkeye116477 pushed a commit to hawkeye116477/Waterfox that referenced this pull request Oct 16, 2019
Add GtkFileChooserNative, new JS properties and other improvements to Waterfox Classic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.