Wrong TypeScript type in jsPDF.table

[jabaa]

The declaration for jsPDF.table in types/index.d.ts is

table(
  x: number,
  y: number,
  data: any,
  headers: string[],
  config: any
): jsPDF;

but in the spec tests in test/specs/cell.spec.js the headers are passed as

headers: {
  name: string;
  prompt: string;
  width: number;
  align: "center" | "left" | "right";
  padding: number
}[]

Changing the headers to a list of strings

var header = [
  "coin",
  "game_group",
  "game_name",
  "game_version",
  "machine",
  "vlt"
]

causes the tests to fail. It seems like it's not possible to create a table in TypeScript without ignoring the declaration.

[HackbrettXXX]

The code suggests that headers may either be an array of strings or and array of {name, prompt, align} objects. If the array of strings isn't working, this is probably a bug. Nonetheless, we should extend the typings to also accept objects.

I think we can also improve the type of the data argument to something like Record<string,string|number|boolen>[].

Could you create a pull request? That would be awesome!

[jabaa]

The bug is probably here. If typeof headers[0] === "object" is true columnWidths is set but in case typeof headers[0] === "string" is true columnWidths isn't set and this causes an error in rect. I don't know how to set columnWidths for an array of strings.

[HackbrettXXX]

I think strings will only work if autoSize is true. We might change the condition here to something like:

if (autoSize || (Array.isArray(headers) && typeof headers[0] === "string")) {

[HackbrettXXX]

Fixed.