-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix the ReDoS-vulnerable regexp #3091
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix the ReDoS-vulnerable regexp addimage.js https://github.com/MrRio/jsPDF/blob/master/src/modules/addimage.js#L633
HackbrettXXX
approved these changes
Feb 11, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright. Looks good. Thanks!
Hey @HackbrettXXX is it possible to push a new release to npm with this change? thanks |
I'm quite busy atm with other stuff, but I'll see if I'll find the time within the next 2-3 weeks. |
sthagen
added a commit
to sthagen/parallax-jsPDF
that referenced
this pull request
Feb 13, 2021
fix ReDoS-vulnerable regexp in addImage (parallax#3091)
This was referenced Mar 10, 2021
This was referenced Mar 12, 2021
Closed
pmstss
added a commit
to pmstss/jsPDF
that referenced
this pull request
Jul 18, 2022
allansson
pushed a commit
to allansson/jsPDF
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix the ReDoS-vulnerable regexp in addimage.js
see #3090