-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Preprocessor "pipeline" #48
Comments
Not yet, but I'll see if i can whip up something soon |
Alright, did some work on a property sorter in 2c2548f Still need to finish the "pipeline" itself |
I'll have to push a new version of spriggit for it to hit, but it would be something like:
Yeah, the pipeline would be a convenience feature for the UI to abstract away running all the commands one by one like you would in a bash script or whatever
Spriggit serializes into/from the Mutagen record definitions, which try to allow a 1:1 representation of what's in the binary file. If the mutagen definitions were to be a So the idea of there being a sorted set is something we need to add on top of the more "raw" definitions. Lots of approaches, but the cleanest imo is to just process the raw files to be how spriggit would prefer them. Making a whole 2nd wrapper of new definitions, /w just one field being a set instead of a list seems unnecessary. There's gonna be a lot of small tweaks spriggit users will want, so just toss it on the pile of something to process before doing a seriaization |
@gir489returns sorry about that! Pull |
It wants a "normal" mod name that can be parsed into a |
yeah, the idea is you have an unsorted esp, you run this to get a sorted one, and serialize that instead Ah, i can probably improve the logic to be less picky for the next version, but for now, let's do this: |
Aight, pull
|
Cool! I'll be working to get this more integrated overall, but hopefully that keeps you going in the meantime |
Are these within the VirtualMachineAdapter of the terminal menu? |
Didn't reproduce. Red herring. Here's a unit test flexing the sort of Terminal Menu in starfield: Is it perhaps something else at play? |
What command are you running for the sort CLI? Are you including the DataFolder parameter? That'll be required for Starfield (almost for every command nowadays, until #81 is done) If omitted, the formID indices can be scrambled (One of starfield's major design flaws) |
alright, add -d "Path/To/Data/Folder" and see if it does better. I'll adjust the script to scream a bit more if missing for starfield |
Yeah, UI needs a repass before 1.0 #85 The CLI and/or logs will give the detail you're hoping for, at the moment. Can you upload |
Let's grab the 0.27 versions of the CLI/UI and give it another spin |
Can you upload your latest CheatTerminal.esp for me to look at? I've only got the one /w |
Alright, pushed a fix to the sort CLI on |
Cool. Yeah, i think we just need to get in the weeds on the details.. as the sorting code is hand crafted, so could be areas that I missed. I think i got the fragments that you were showing in your previous pictures. Grab the latest cli from |
Thanks for the back and forth! |
For example, CK randomizes script properties. Some people might want that ordered, and so a preprocessor cmd could be added that did the job before flowing into the spriggit call.
Would be nice to have this in the UI somehow to where it could run these for the user as part of the single click
The text was updated successfully, but these errors were encountered: