From 59c2b77fc6ef3a8a3131b612c7e0186e7d089eb0 Mon Sep 17 00:00:00 2001 From: Christopher Bisom Date: Tue, 16 Apr 2024 08:02:25 -0400 Subject: [PATCH] fix health check ping --- .github/workflows/ci.yaml | 6 ------ docker-compose-dev-ga.yaml | 2 +- docker-compose-dev.yaml | 2 +- 3 files changed, 2 insertions(+), 8 deletions(-) diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml index 91ad690..8dedd17 100644 --- a/.github/workflows/ci.yaml +++ b/.github/workflows/ci.yaml @@ -19,12 +19,6 @@ jobs: sudo curl -L "https://github.com/docker/compose/releases/download/1.29.2/docker-compose-$(uname -s)-$(uname -m)" -o /usr/local/bin/docker-compose sudo chmod +x /usr/local/bin/docker-compose - - name: Check secret is set - env: - SECRET: ${{ secrets.DATABASE_DB }} - run: | - echo "Length of secret: ${#DATABASE_DB}" - - name: Build run: | docker image prune -a -f diff --git a/docker-compose-dev-ga.yaml b/docker-compose-dev-ga.yaml index 1bfd913..0e8f20b 100644 --- a/docker-compose-dev-ga.yaml +++ b/docker-compose-dev-ga.yaml @@ -35,6 +35,6 @@ services: ports: - "3306:3306" healthcheck: - test: [ "CMD", "mysqladmin", "ping", "-h", "localhost" ] # We'll wait until the DB is ready to accept connections to start up dependent services + test: [ "CMD", "mysqladmin", "ping", "-h", "db" ] # We'll wait until the DB is ready to accept connections to start up dependent services timeout: 20s retries: 10 diff --git a/docker-compose-dev.yaml b/docker-compose-dev.yaml index fa2f7c4..cd4eef5 100644 --- a/docker-compose-dev.yaml +++ b/docker-compose-dev.yaml @@ -50,6 +50,6 @@ services: ports: - "3306:3306" healthcheck: - test: [ "CMD", "mysqladmin", "ping", "-h", "localhost" ] # We'll wait until the DB is ready to accept connections to start up dependent services + test: [ "CMD", "mysqladmin", "ping", "-h", "db" ] # We'll wait until the DB is ready to accept connections to start up dependent services timeout: 20s retries: 10