Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallet phrase truncation #11

Open
leto opened this issue Jan 2, 2018 · 2 comments
Open

Wallet phrase truncation #11

leto opened this issue Jan 2, 2018 · 2 comments

Comments

@leto
Copy link
Member

leto commented Jan 2, 2018

wallet_phrase

We need to at least warn people when we truncate their seed phrase to a max size, or they could use a really long one and then not be able to log in. THINK OF THE SUPPORT REQUESTS!!!!

I would really like to see our max size changed, if we cannot let arbitrary size, lets do 128 or 256 characters.

Also, 1234....1234.... should not be allowed. We might want to add some kind of "password strength" thing.

@leto
Copy link
Member Author

leto commented Jan 6, 2018

10 HUSH for basic "UI truncation warning", 20 HUSH for a nice password strength JS library to give user feedback.

Extra HUSH for memes

@TheTrunk
Copy link

Expanded to 256 characters with button to revert back to 64. The revert back is just using maxlenght in input section. 256 required changes in bitcoinjs package.

password strength is an interesting idea. The user has to use more then 16 characters to create the webwallet - this is basically unbruteforceable. Checking for small/big letter, numbers, special symbols is not a good way to go as we want the phrase to be random but still to be easy to rembember - so random words. So we need to create our own implementation of password strenghtnest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants