Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent kmer size defaults #141

Closed
mbhall88 opened this issue Nov 15, 2021 · 2 comments
Closed

Inconsistent kmer size defaults #141

mbhall88 opened this issue Nov 15, 2021 · 2 comments

Comments

@mbhall88
Copy link
Member

The default kmer size for making custom panels is set to 31

parser_dump.add_argument(
"--kmer", metavar="kmer", type=int, help="kmer length", default=31
)

parser_make_probes.add_argument(
"-k", "--kmer", type=int, help="kmer length", default=31
)

However, the default mykrobe (TB) panels is built with a kmer size of 21, the docs for making probes and lineage panels suggests 21, and the default for predict is also 21

DEFAULT_KMER_SIZE = os.environ.get("KMER_SIZE", 21)

This is pretty confusing. Is this intentional, or should we change these to be consistent? @martinghunt @iqbal-lab

Again, I can add this to #138 if there are any changes to be made.

@iqbal-lab
Copy link
Collaborator

Not intentional

@martinghunt
Copy link
Member

Not intentional. Makes sense to change it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants