From 1b8d312bf61b3cf32c5b1d5c4e3233770c610586 Mon Sep 17 00:00:00 2001 From: Ashok Menon Date: Mon, 29 Apr 2024 14:59:22 +0100 Subject: [PATCH] fixup: Add TODOs for bugfixes --- crates/sui-graphql-rpc/src/types/dynamic_field.rs | 2 ++ crates/sui-graphql-rpc/src/types/object.rs | 1 + 2 files changed, 3 insertions(+) diff --git a/crates/sui-graphql-rpc/src/types/dynamic_field.rs b/crates/sui-graphql-rpc/src/types/dynamic_field.rs index b6ee6c7d59526..46b2cee59051c 100644 --- a/crates/sui-graphql-rpc/src/types/dynamic_field.rs +++ b/crates/sui-graphql-rpc/src/types/dynamic_field.rs @@ -108,6 +108,8 @@ impl DynamicField { ctx, self.df_object_id, Object::under_parent( + // TODO (RPC-131): The dynamic object field value's version should be bounded by + // the field's parent version, not the version of the field object itself. self.super_.super_.version_impl(), self.super_.super_.checkpoint_viewed_at, ), diff --git a/crates/sui-graphql-rpc/src/types/object.rs b/crates/sui-graphql-rpc/src/types/object.rs index 32d7a4c0f7850..0336d5667a023 100644 --- a/crates/sui-graphql-rpc/src/types/object.rs +++ b/crates/sui-graphql-rpc/src/types/object.rs @@ -1337,6 +1337,7 @@ fn objects_query(filter: &ObjectFilter, range: AvailableRange, page: &Page