Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass empty batches/transactions to ExecutorState #5322

Open
asonnino opened this issue Aug 12, 2022 · 2 comments · Fixed by MystenLabs/narwhal#818
Open

Pass empty batches/transactions to ExecutorState #5322

asonnino opened this issue Aug 12, 2022 · 2 comments · Fixed by MystenLabs/narwhal#818
Assignees
@asonnino
Labels
good first issue Small issues that are useful to get used to the codebase narwhal

Comments

@asonnino
Copy link
Contributor

asonnino commented Aug 12, 2022 •
edited
Loading

Currently the narwhal executor core simply skips empty batches. It seems however better to pass them forward to the executor state (who can make informed decision based on those data).

We should modify the ExecutionState interface in some way to let us know about the beginning end of batches. This would be similar to the Tendermint ABCI.
@asonnino asonnino self-assigned this Aug 12, 2022
@asonnino asonnino added the good first issue Small issues that are useful to get used to the codebase label Aug 12, 2022
@asonnino
Copy link
Contributor Author

This issue is an idea from Filecoin: https://hackmd.io/pGpXHTTITl6iSLfmvb3KBw

This was referenced Aug 18, 2022
Closed
Merged
@huitseeker
Copy link
Contributor

Reopening because of MystenLabs/narwhal#859

@huitseeker huitseeker reopened this Sep 27, 2022
@akichidis akichidis transferred this issue from MystenLabs/narwhal Oct 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asonnino asonnino

Labels
good first issue Small issues that are useful to get used to the codebase narwhal
Projects
None yet
Milestone
No milestone
3 participants
@huitseeker @akichidis @asonnino