From b26637953998d15cbc20b1ad1a79475e04b95fb0 Mon Sep 17 00:00:00 2001 From: rrgoetz Date: Tue, 22 Oct 2024 08:27:41 -1000 Subject: [PATCH] Address PR issues from Bryan --- src/utilities/sequence-editor/from-seq-json.ts | 2 +- src/utilities/sequence-editor/to-seq-json.ts | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/src/utilities/sequence-editor/from-seq-json.ts b/src/utilities/sequence-editor/from-seq-json.ts index af541313ec..14f5fc1954 100644 --- a/src/utilities/sequence-editor/from-seq-json.ts +++ b/src/utilities/sequence-editor/from-seq-json.ts @@ -120,7 +120,7 @@ function seqJsonVariableToSequence( sequence += variables .map(variable => { const name = variable.name; - const type = variable.type ? ' ' + variable.type : ''; + const type = variable.type ? ` ${variable.type}` : ''; const enumName = variable.enum_name ? ' ' + variable.enum_name : ''; const allowableRanges = variable.allowable_ranges ? ` "${variable.allowable_ranges.map(range => `${range.min}...${range.max}`).join(',')}"` diff --git a/src/utilities/sequence-editor/to-seq-json.ts b/src/utilities/sequence-editor/to-seq-json.ts index 3f352dd835..bb863b5d23 100644 --- a/src/utilities/sequence-editor/to-seq-json.ts +++ b/src/utilities/sequence-editor/to-seq-json.ts @@ -567,8 +567,10 @@ function parseAllowableRanges(text: string, rangeNode: any): { max: number; min: const rangeMatch = /^([-+]?\d+)?(\.\.\.)([-+]?\d+)?$/.exec(range.replaceAll('"', '').trim()); if (rangeMatch) { const [, min, , max] = rangeMatch; - const maxNum = !isNaN(Number(max)) ? Number(max) : Infinity; - const minNum = !isNaN(Number(min)) ? Number(min) : -Infinity; + const parsedMaxNum = Number(max); + const parsedMinNum = Number(min); + const maxNum = !Number.isNaN(parsedMaxNum) ? parsedMaxNum : Infinity; + const minNum = !Number.isNaN(parsedMinNum) ? parsedMinNum : -Infinity; return { max: maxNum, min: minNum }; }