Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update PDS Deep "Registry" Archive and remove workaround + implement latest-only-feature per API updates #107

Closed
4 tasks
nutjob4life opened this issue Apr 27, 2021 · 4 comments
Assignees

Comments

@nutjob4life
Copy link
Member

nutjob4life commented Apr 27, 2021

These aren't blockers like NASA-PDS/registry-api#466 but should be addressed so we can remove the "workaround" command-line arguments:

Once the corresponding API improvements are made, the workarounds may be removed and we can call this done.

Engineering Details

  • remove --disable-pagination-workaround flag and functionality
  • remove support --include-latest-collection-only flag and develop functionality to support this

(EDIT: changed "remove" to "support"; we don't want to remove the flag. We want to make it work.)

@nutjob4life nutjob4life self-assigned this Apr 27, 2021
@jordanpadams jordanpadams transferred this issue from NASA-PDS/validate Apr 28, 2021
@jordanpadams jordanpadams transferred this issue from NASA-PDS/pds-api Apr 28, 2021
@jordanpadams jordanpadams changed the title Improvements in API for "performance" workarounds in PDS Deep "Registry" Archive Update PDS Deep "Registry" Archive and remove workarounds per API updates Jul 3, 2021
@jordanpadams jordanpadams added this to the 13.Abebe.Bikila milestone Sep 3, 2021
@jordanpadams
Copy link
Member

jordanpadams commented Sep 8, 2021

@nutjob4life we unfortunately do not have this functionality deployed somewhere... BUT the capabilities have been implemented. could we maybe try this with by deploying a local instance of the registry? https://github.com/NASA-PDS/pds-registry-app#run

@nutjob4life
Copy link
Member Author

nutjob4life commented Sep 8, 2021

Thanks @jordanpadams. The instructions you linked are much better than the ones at https://github.com/NASA-PDS/registry-api-service

Currently stuck on [ERROR] Could not find datatype for field 'cart:Polar_Stereographic/cart:straight_vertical_longitude_from_pole' but reading up on registry customization 👍

EDIT: apparently there's an -updateSchema n flag which sounds unsafe but should be fine for testing.

@nutjob4life
Copy link
Member Author

FYI @jordanpadams --include-latest-collection-only isn't a workaround. It's a feature! We don't want to remove it; we want to support it the way we do for on-disk bundles.

(I mean, I can remove it—that'd be even easier.)

@nutjob4life nutjob4life changed the title Update PDS Deep "Registry" Archive and remove workarounds per API updates Update PDS Deep "Registry" Archive and remove workaround + implement latest-only-feature per API updates Sep 22, 2021
@jordanpadams jordanpadams added B12.1 and removed B12.0 labels Sep 24, 2021
@tloubrieu-jpl
Copy link
Member

@nutjob4life I deployed the update related to ticket NASA-PDS/pds-api#115 on pds-gamma

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants