Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

/classes endpoint does not work in a browser #200

Closed
tloubrieu-jpl opened this issue Dec 10, 2022 · 2 comments
Closed

/classes endpoint does not work in a browser #200

tloubrieu-jpl opened this issue Dec 10, 2022 · 2 comments
Assignees
Labels
B13.1 bug Something isn't working s.medium Medium level severity

Comments

@tloubrieu-jpl
Copy link
Member

🐛 Describe the bug

I believe this can be reproduced with curl request:
curl http://localhost:8081/classes -H 'Accept:text/html'

@alexdunnjpl
Copy link
Contributor

alexdunnjpl commented Mar 14, 2023

@tloubrieu-jpl I replicated this (having neglected to update main from its few-week-old version) and wrote a fix, but with an updated version of main I'm no longer able to replicate it. I thought it might have been incidentally resolved in 87814ae or 1ce1306, but it's non-reproducible even as of revision e2162a1 (and going much further back is turning out to be more of a pain than it's worth due to environment minutiae).

Suggest closing as it's no longer reproducible, but it's relevant that ClassesSerializer is not included in the converters and it's still the case that the log message is in the wrong place (it checks size before anything's actually added, so always logs zero converters) so that fix (ae6ce91) should still make it in.

Should the ClassesSerializer be added to the converters, or deleted from the codebase, given that it appears unnecessary?

@tloubrieu-jpl
Copy link
Member Author

tloubrieu-jpl commented Mar 15, 2023

Right I am not reproducing it either, this has been field without knowing as a consequence of ticket #248

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
B13.1 bug Something isn't working s.medium Medium level severity
Projects
None yet
Development

No branches or pull requests

3 participants