-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Java params and Docker image to expand JVM memory beyond 50% #300
Comments
@tloubrieu-jpl @jimmie @alexdunnjpl not sure who wants to do this, so assigned to you all. should hopefully be a quick-ish PR, review, merge. |
@jimmie do we want to fudge this into the existing tagged docker image to be able to use in ECS right now? |
assigning to @alexdunnjpl . ping @jimmie or @tloubrieu-jpl if you have questions about what is going on here, or me for questions in priority |
@alexdunnjpl - let me know if you'd like for me to go over where things are and what they (at least intend) to do... |
@jimmie @jordanpadams I get the feeling this is one of those "takes longer to explain than to do" but at least I'll learn 😅
|
@alexdunnjpl - I agree that most of the time, hardcoding is the root of most evils. However, the terraform script likewise specifies the memory of the ECS instance (i.e. container) - so including explicit memory setting as part of the same script wouldn't be as terrible (and it is also more accountable that way since it is clearly specified in the file). That said however, the docker build is currently not yet part of the terraform. It wouldn't be difficult, but I would just want to make sure that terraform verifies if a new build is needed based on combination of name/tag and checksum (that is why I was holding off on including that in terraform). Perhaps we can work this in parallel... |
@jimmie in the immediate-term should I just go ahead and hardcode it into the Dockerfile, then, and we can worry about the single-source-of-truth approach later on? |
@alexdunnjpl - yes, I would think that's the best solution for now |
💡 Description
Default Java 11 JVM config is to use 50% of available memory. Since registry-api is running on it's own ECS cluster, we want to run this with more available memory (75%?)
The text was updated successfully, but these errors were encountered: