Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pre-commit modifies generated REQUIREMENTS.md files #58

Closed
nutjob4life opened this issue Jun 24, 2022 · 0 comments · Fixed by #59
Closed

Pre-commit modifies generated REQUIREMENTS.md files #58

nutjob4life opened this issue Jun 24, 2022 · 0 comments · Fixed by #59
Assignees
@nutjob4life
Labels
bug Something isn't working p.should-have

Comments

@nutjob4life
Copy link
Member

🐛 Describe the bug

The pds-github-util generates REQUIREMENTS.md files automatically. But then by the time you run tox or do a commit, the pre-commit hook doesn't like the whitespace and end-of-file issues in REQUIREMENTS.md and modifies it too.

It shouldn't do that.

🕵️ Expected behavior

Running tox, or git commit, or simply python -m pre_commit run --color=always --all should leave REQUIREMENTS.md (and Brittney) alone.

⚙️ Engineering Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nutjob4life nutjob4life

Labels
bug Something isn't working p.should-have
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix tox error with requirements gen NASA-PDS/template-repo-python
2 participants
@nutjob4life @jordanpadams