Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add v1 tag #4

Closed
koppor opened this issue Dec 14, 2020 · 4 comments
Closed

Add v1 tag #4

koppor opened this issue Dec 14, 2020 · 4 comments
Assignees
Labels
Bug Something isn't working

Comments

@koppor
Copy link
Contributor

koppor commented Dec 14, 2020

When running the example config, I get

Error: Unable to resolve action `NBprojekt/gource-action@v1`, unable to find version `v1`

The current tags do not list v1:

grafik

I think, v1.0.1 should be tagged as v1, too.

(See JabRef/jabref#7193 for the usage)

@NBprojekt NBprojekt self-assigned this Dec 14, 2020
@NBprojekt NBprojekt added the Bug Something isn't working label Dec 14, 2020
@NBprojekt
Copy link
Owner

NBprojekt commented Dec 14, 2020

Thank you for this issue.

For this actions I allways used the @master tag thats why I did not notice this issue.

This issue should be solved by the v1 branch and your expected syntax should work with the latest release v1.0.1.

@NBprojekt
Copy link
Owner

Feedback if this works for you would be great @koppor ✌️

@koppor
Copy link
Contributor Author

koppor commented Dec 15, 2020

Thank you for the quick action taken. Typically, there isn't a v1 branch, just a "moving" v1 tag.

I got "v1" out of your README.md, where I copied and pasted the minimal example to get the action running.

@NBprojekt
Copy link
Owner

NBprojekt commented Dec 15, 2020

IMHO, "moving tags" or "re tagging" is kinda hacky.

Therefore I found this interesting issue and I wanted to try it out for some time using branches instead of moving tags.

Also note that nothing changes for the use

Say v1 points to v1.0.0, and a new version v1.1.0 has been tagged. After successfully testing v1.1.0, v1 could simply be fast-forwarded to v1.1.0. There is no need to force anything, and from a user's perspective, everything remains the same, e.g.
using an action would still look like this:

uses: actions/custom-action@v1

In this case you can still use: uses: nbprojekt/gource-action@v1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants