Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve testing for interp_hybrid_to_pressure_extrapolate #425

Open
kafitzgerald opened this issue Jun 21, 2023 · 0 comments · May be fixed by #427
Open

Improve testing for interp_hybrid_to_pressure_extrapolate #425

kafitzgerald opened this issue Jun 21, 2023 · 0 comments · May be fixed by #427
Labels
developer feature For development standardization / best practices / enhancement

Comments

@kafitzgerald
Copy link
Contributor

Describe the feature you'd like added to this project
Use a more robust subset of data for the Test_interp_hybrid_to_pressure_extrapolate tests.

Describe the solution you'd like
At a minimum, we should select a test data subset the covers more of the conditions we are hoping to test.

Additional context
This would have caught the bug in issue #423.
@kafitzgerald kafitzgerald added the developer feature For development standardization / best practices / enhancement label Jun 21, 2023
@kafitzgerald kafitzgerald self-assigned this Jun 21, 2023
@kafitzgerald kafitzgerald linked a pull request Jun 22, 2023 that will close this issue
Draft
8 tasks
@erogluorhan erogluorhan added this to the Testing milestone Sep 8, 2023
@anissa111 anissa111 removed this from the Testing milestone Sep 12, 2023
@kafitzgerald kafitzgerald removed their assignment Oct 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
developer feature For development standardization / best practices / enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Improve testing for interp_hybrid_to_pressure_extrapolate kafitzgerald/geocat-comp
3 participants
@kafitzgerald @erogluorhan @anissa111