Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SqlPersistanceFactory requires an explicit sql dialect when provided an IConnectionFactory #3

Open
kblooie opened this issue May 23, 2015 · 0 comments

Comments

@kblooie
Copy link
Contributor

kblooie commented May 23, 2015

From @Jared314 on February 17, 2015 5:5

The NEventStore.Serialization.SqlPersistanceFactory constructor that accepts a database connection string name, automatically resolve the sql dialect if non is provided. But, the constructor that accepts an IConnectionFactory requires an explicit sql dialect. The IConnectionFactory interface contains a method to get the provider type information and could also automatically resolve the dialect.

I currently utilize IConnectionFactory to wrap custom database resolution logic, and had to implement custom dialect detection. Is the behavior difference intentional? Should I not be using the UsingSqlPersistence(IConnectionFactory factory) overload for wireup?

Copied from original issue: NEventStore/NEventStore#395

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant