Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Storage initialisation fails when a Commits table exists in another schema #7

Open
kblooie opened this issue May 23, 2015 · 2 comments

Comments

@kblooie
Copy link
Contributor

kblooie commented May 23, 2015

From @adamralph on May 7, 2014 10:55

Perhaps an edge case which you don't care about, but I thought I'd put it here FWIW.

If I have a Commits table in a Foo schema, this line shortcircuits the schema creation

IF EXISTS(SELECT * FROM sysobjects WHERE name='Commits' AND xtype = 'U') RETURN;

I guess it needs to check if it's in the target schema, not just it's name.

Copied from original issue: NEventStore/NEventStore#343

@kblooie
Copy link
Contributor Author

kblooie commented May 23, 2015

From @damianh on August 13, 2014 15:30

Thought about trying something smarter but couldn't figure out how to get the schema name in the end. I'm just going to remove this check. If the table exists, SqlPersistenceEngine.Initialize() will eat the exceptions anyway.

@kblooie
Copy link
Contributor Author

kblooie commented May 23, 2015

From @damianh on February 22, 2015 15:47

Reverting this "fix" to address #373.

Re-opening issue as I'd like a better real solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant