Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:table & i18n): fix table style & export i18n interface #1163

Merged
merged 2 commits into from
Mar 17, 2018
Merged

fix(module:table & i18n): fix table style & export i18n interface #1163

merged 2 commits into from
Mar 17, 2018

Conversation

vthinkxie
Copy link
Member

@vthinkxie vthinkxie commented Mar 17, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A
close #1160 close #1154

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Mar 17, 2018

Codecov Report

Merging #1163 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1163      +/-   ##
==========================================
+ Coverage   96.76%   96.76%   +<.01%     
==========================================
  Files         184      184              
  Lines        7571     7581      +10     
  Branches      989      989              
==========================================
+ Hits         7326     7336      +10     
  Misses         55       55              
  Partials      190      190
Impacted Files Coverage Δ
components/table/nz-th.component.ts 99.09% <100%> (+0.01%) ⬆️
components/table/nz-table.component.ts 95.48% <100%> (+0.24%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3bcd50d...3c67034. Read the comment docs.

@vthinkxie vthinkxie merged commit fdd03d7 into NG-ZORRO:master Mar 17, 2018
@vthinkxie vthinkxie deleted the fix-table-shadow branch October 10, 2018 02:49
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…-ZORRO#1163)

* fix(module:table & i18n): fix table style & export i18n interface

* test(module:table): add test for table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant