Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:modal): add afterOpen/afterClose/afterAllClose/closeAll/openModals, adjust the boolean props and changeBodyOverflow and complete testing. #1165

Merged
merged 3 commits into from
Mar 19, 2018

Conversation

wilsoncook
Copy link
Member

…capabilities

close #1155

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1155

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Mar 17, 2018

Codecov Report

Merging #1165 into master will increase coverage by 0.02%.
The diff coverage is 98.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1165      +/-   ##
==========================================
+ Coverage   96.75%   96.78%   +0.02%     
==========================================
  Files         184      185       +1     
  Lines        7586     7653      +67     
  Branches      991     1001      +10     
==========================================
+ Hits         7340     7407      +67     
  Misses         56       56              
  Partials      190      190
Impacted Files Coverage Δ
components/modal/nz-modal.module.ts 100% <100%> (ø) ⬆️
components/modal/nz-modal-ref.class.ts 100% <100%> (ø)
components/modal/nz-modal-control.service.ts 100% <100%> (ø)
components/modal/nz-modal.service.ts 91.17% <96.15%> (+1.52%) ⬆️
components/modal/nz-modal.component.ts 96.46% <98.8%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ab37862...7f37452. Read the comment docs.

@wilsoncook wilsoncook changed the title feat(module:modal): add afterClose and more to improve communication … [WIP] feat(module:modal): add afterClose and more to improve communication … Mar 17, 2018
…adjust the boolean props and changeBodyOverflow, complete testing.

close NG-ZORRO#1162
@wilsoncook wilsoncook changed the title [WIP] feat(module:modal): add afterClose and more to improve communication … feat(module:modal): add afterOpen/afterClose/afterAllClose/closeAll/openModals, adjust the boolean props and changeBodyOverflow and complete testing. Mar 19, 2018
@vthinkxie vthinkxie merged commit 10227b8 into NG-ZORRO:master Mar 19, 2018
@wilsoncook wilsoncook deleted the modal_enhancement branch March 20, 2018 02:05
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…penModals, adjust the boolean props and changeBodyOverflow and complete testing. (NG-ZORRO#1165)

* feat(module:modal): add afterClose and more to improve communication capabilities

close NG-ZORRO#1155

* feat(module:modal): add afterOpen/afterAllClose/closeAll/openModals, adjust the boolean props and changeBodyOverflow, complete testing.

close NG-ZORRO#1162

* docs(changelog): add 0.7.0-beta.2 changelog for modal
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[0.7.0-beta.1] modal: some problems via services
2 participants