Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:mention): add mention component #1182

Merged
merged 1 commit into from
Apr 4, 2018

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Mar 20, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[X] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[] Yes
[ ] No

Other information

style(module:mention): formatting the code

docs(module:mention): add the docs & demo

refactor(module:mention): refactor

test(module:mention): add test

fix(module:mention): fix getMentions method

update PROGRESS.md
@codecov
Copy link

codecov bot commented Mar 27, 2018

Codecov Report

Merging #1182 into master will increase coverage by 0.05%.
The diff coverage is 99.53%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1182      +/-   ##
==========================================
+ Coverage   97.18%   97.23%   +0.05%     
==========================================
  Files         185      191       +6     
  Lines        7705     7926     +221     
  Branches     1015     1040      +25     
==========================================
+ Hits         7488     7707     +219     
- Misses         25       26       +1     
- Partials      192      193       +1
Impacted Files Coverage Δ
components/mention/mention-suggestions.ts 100% <100%> (ø)
components/mention/mention-trigger.ts 100% <100%> (ø)
components/mention/mention.module.ts 100% <100%> (ø)
components/mention/mention.component.ts 99.39% <99.39%> (ø)
components/table/nz-table.component.ts 94.83% <0%> (-0.65%) ⬇️
components/input/index.ts 100% <0%> (ø)
components/input/public-api.ts 100% <0%> (ø)
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 880f0e8...a8eb482. Read the comment docs.

@hsuanxyz hsuanxyz changed the title WIP(module:mention): add mention component feat(module:mention): add mention component Mar 27, 2018
@hsuanxyz
Copy link
Member Author

@vthinkxie work done

@vthinkxie vthinkxie merged commit e28c1b5 into NG-ZORRO:master Apr 4, 2018
@hsuanxyz hsuanxyz deleted the mention branch May 2, 2018 03:59
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
style(module:mention): formatting the code

docs(module:mention): add the docs & demo

refactor(module:mention): refactor

test(module:mention): add test

fix(module:mention): fix getMentions method

update PROGRESS.md
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants