Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:transfer): removed change detection #1260

Merged
merged 1 commit into from
Apr 4, 2018
Merged

fix(module:transfer): removed change detection #1260

merged 1 commit into from
Apr 4, 2018

Conversation

cipchk
Copy link
Member

@cipchk cipchk commented Apr 2, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #996

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Apr 2, 2018

Codecov Report

Merging #1260 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1260      +/-   ##
==========================================
- Coverage   97.18%   97.18%   -0.01%     
==========================================
  Files         185      185              
  Lines        7705     7702       -3     
  Branches     1015     1015              
==========================================
- Hits         7488     7485       -3     
  Misses         25       25              
  Partials      192      192
Impacted Files Coverage Δ
components/transfer/nz-transfer-list.component.ts 98.52% <ø> (ø) ⬆️
components/transfer/nz-transfer.component.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 880f0e8...7de2849. Read the comment docs.

@vthinkxie vthinkxie merged commit d507848 into NG-ZORRO:master Apr 4, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants