Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:mention): getMention method should kepp the mention prefix #1287

Merged
merged 1 commit into from
Apr 11, 2018

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Apr 9, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[X] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

没有保留前缀,无法区分类型。

getMention("... @vthinkxie ... #1142") // ["vthinkxie",  "1142"]

Issue Number: N/A

What is the new behavior?

保留前缀,能够区分类型。

getMention("... @vthinkxie ... #1142") // ["@vthinkxie",  "#1142"]

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@codecov
Copy link

codecov bot commented Apr 9, 2018

Codecov Report

Merging #1287 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1287   +/-   ##
=======================================
  Coverage   97.26%   97.26%           
=======================================
  Files         191      191           
  Lines        7926     7926           
  Branches     1041     1041           
=======================================
  Hits         7709     7709           
  Misses         25       25           
  Partials      192      192

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c3b9c39...5255481. Read the comment docs.

@vthinkxie vthinkxie merged commit 7925f48 into NG-ZORRO:master Apr 11, 2018
@hsuanxyz hsuanxyz deleted the fix-get-mentions branch May 2, 2018 03:58
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants