Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Angular Package Format compatible distribution #144

Closed
8 tasks done
trotyl opened this issue Aug 24, 2017 · 6 comments · Fixed by #240
Closed
8 tasks done

Angular Package Format compatible distribution #144

trotyl opened this issue Aug 24, 2017 · 6 comments · Fixed by #240
Assignees

Comments

@trotyl
Copy link
Contributor

trotyl commented Aug 24, 2017

I'm submitting a...


[ ] Bug report  
[x] Feature request
[ ] Documentation issue or request
[ ] Regression (a behavior that used to work and stopped working in a new release)
[ ] Support request => Please do not submit support request here

Current behavior

Whatever opposite to expected behavior.

Expected behavior

Goals

  • Clean distribution, no sources, tests or other meaningless files;
  • Main FESM15 distribution following Angular Package Format for entire lib;
  • Main FESM5 distribution following Angular Package Format for entire lib;
  • Main UMD distribution following Angular Package Format for entire lib (with minified version);
  • Plunker template/starter;
  • Compatible with Angular CLI (add integration test);
  • Compatible with Webpack (add integration test);
  • Compatible with Rollup (add integration test);

Non-Goals

  • Compatible with Closure Compiler ADVANCED mode (too hard);
  • Compatible with server-side rendering (could be done later);
  • Well-defined documentation for all possible usages (would be done in separate card);
  • Correct sourcemap to original .ts files (having technical problems);
  • Individual bundle for each component (secondary entries in Angular package are individual modules, not partial ones, would require new designs);
  • Stackblitz template/starter (it's unable to customize package source, need to wait for release);

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment


Angular version: X.Y.Z

ng-zorro-antd version: X.Y.Z

Browser:
- [ ] Chrome (desktop) version XX
- [ ] Firefox version XX
- [ ] Safari (desktop) version XX
- [ ] IE version XX
 
For Tooling issues:
- Node version: XX  
- Platform:  

Others:

@trotyl
Copy link
Contributor Author

trotyl commented Sep 6, 2017

Will follow the new format introduced by angular/angular@fd701b0.

@trotyl
Copy link
Contributor Author

trotyl commented Sep 7, 2017

Initial version of plunker template here.

@cipchk
Copy link
Member

cipchk commented Sep 7, 2017

Don't dismiss a follower and expect them to keep items!

+++++++++++++1 for @trotyl

@yupengfei
Copy link

Will Closure Compiler ADVANCED possible in future?

@trotyl
Copy link
Contributor Author

trotyl commented Oct 20, 2017

@yupengfei Not even a feature request for that yet.

@lock
Copy link

lock bot commented Feb 19, 2019

This thread has been automatically locked because it has not had recent activity. Please open a new issue for related bugs and link to relevant comments in this thread.

@lock lock bot locked as resolved and limited conversation to collaborators Feb 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants