Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:date-picker): improve the horizontal position adaptability #1495

Merged
merged 2 commits into from
May 24, 2018

Conversation

wilsoncook
Copy link
Member

close #1450

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1450

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented May 24, 2018

Codecov Report

Merging #1495 into master will increase coverage by <.01%.
The diff coverage is 90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1495      +/-   ##
==========================================
+ Coverage   96.92%   96.92%   +<.01%     
==========================================
  Files         222      222              
  Lines        9500     9506       +6     
  Branches     1296     1297       +1     
==========================================
+ Hits         9208     9214       +6     
  Misses         42       42              
  Partials      250      250
Impacted Files Coverage Δ
...omponents/date-picker/abstract-picker.component.ts 98.52% <100%> (ø) ⬆️
components/date-picker/month-picker.component.ts 100% <100%> (ø) ⬆️
components/date-picker/picker.component.ts 97.53% <83.33%> (+0.12%) ⬆️
components/modal/nz-modal.component.ts 96.37% <0%> (+0.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6f394a4...1e9ec24. Read the comment docs.

@vthinkxie vthinkxie merged commit 64f5ce5 into NG-ZORRO:master May 24, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
…NG-ZORRO#1495)

* fix(module:date-picker): improve the horizontal position adaptability

close NG-ZORRO#1450

* rename nzPlaceholder to nzPlaceHolder
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: nz-range-picker Cover up the other half when the component near the scroll bar
2 participants