Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:nz-alert): emit close after fade animation is done #1667

Merged
merged 1 commit into from
Jun 16, 2018

Conversation

dmytroyarmak
Copy link
Contributor

Fixes #1666

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

nzOnClose is emitted immediately and as a result, ngIfon alert hides it before the animation is done

Issue Number: #1666

What is the new behavior?

nzOnClose is emitted only when a fade animation is finished, so you will be able to see animation if you are controlling the visibility of alert with ngIf

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Jun 15, 2018

Codecov Report

Merging #1667 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #1667      +/-   ##
=========================================
+ Coverage      96%     96%   +<.01%     
=========================================
  Files         466     466              
  Lines       11076   11078       +2     
  Branches     1459    1460       +1     
=========================================
+ Hits        10633   10635       +2     
  Misses        125     125              
  Partials      318     318
Impacted Files Coverage Δ
components/alert/nz-alert.component.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fc67ce5...263f012. Read the comment docs.

@vthinkxie vthinkxie merged commit 6b31ca3 into NG-ZORRO:master Jun 16, 2018
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nzOnClose is emitted for nz-alert before fade animation is finished
2 participants