Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:radio): fix radio in reactive form #1748

Merged
merged 1 commit into from
Jun 28, 2018
Merged

fix(module:radio): fix radio in reactive form #1748

merged 1 commit into from
Jun 28, 2018

Conversation

vthinkxie
Copy link
Member

close #1735

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Jun 28, 2018

Codecov Report

Merging #1748 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1748      +/-   ##
==========================================
- Coverage   96.06%   96.05%   -0.01%     
==========================================
  Files         466      466              
  Lines       11145    11146       +1     
  Branches     1456     1456              
==========================================
  Hits        10706    10706              
  Misses        127      127              
- Partials      312      313       +1
Impacted Files Coverage Δ
components/radio/nz-radio.component.ts 98.79% <ø> (ø) ⬆️
components/radio/nz-radio-group.component.ts 100% <100%> (ø) ⬆️
components/table/nz-table.component.ts 94.76% <0%> (-0.59%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aeb485f...c1ce64e. Read the comment docs.

@vthinkxie vthinkxie merged commit b7a831d into NG-ZORRO:master Jun 28, 2018
wenqi73 pushed a commit to wenqi73/ng-zorro-antd that referenced this pull request Aug 27, 2018
@vthinkxie vthinkxie deleted the fix-radio-form branch October 10, 2018 02:49
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

radio-group has error when disabled in reactive-forms
1 participant