Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tree-select): width is 0 when trigger element is invisible #1775

Merged
merged 1 commit into from
Jul 2, 2018

Conversation

hsuanxyz
Copy link
Member

@hsuanxyz hsuanxyz commented Jul 2, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1772

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Jul 2, 2018

Codecov Report

Merging #1775 into master will decrease coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1775      +/-   ##
==========================================
- Coverage   96.05%   96.03%   -0.02%     
==========================================
  Files         466      466              
  Lines       11153    11157       +4     
  Branches     1458     1459       +1     
==========================================
+ Hits        10713    10715       +2     
  Misses        127      127              
- Partials      313      315       +2
Impacted Files Coverage Δ
components/tree-select/nz-tree-select.component.ts 98.6% <100%> (-0.45%) ⬇️
components/time-picker/time-holder.ts 95.91% <0%> (-1.03%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92675e4...8db5579. Read the comment docs.

@vthinkxie vthinkxie merged commit 4eb039a into NG-ZORRO:master Jul 2, 2018
wenqi73 pushed a commit to wenqi73/ng-zorro-antd that referenced this pull request Aug 27, 2018
@hsuanxyz hsuanxyz deleted the tree-select/fix-in-modal branch October 23, 2018 11:20
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants