Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:tabs): prevent focus cause scroll offset #1845

Merged
merged 1 commit into from
Jul 22, 2018

Conversation

hsuanxyz
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1821

What is the new behavior?

Reset scrollLeft & document.activeElement when scroll.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Jul 19, 2018

Codecov Report

Merging #1845 into master will decrease coverage by <.01%.
The diff coverage is 87.5%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1845      +/-   ##
==========================================
- Coverage   96.07%   96.07%   -0.01%     
==========================================
  Files         466      466              
  Lines       11173    11180       +7     
  Branches     1461     1463       +2     
==========================================
+ Hits        10735    10741       +6     
  Misses        126      126              
- Partials      312      313       +1
Impacted Files Coverage Δ
components/tabs/nz-tabset.component.ts 96.58% <87.5%> (-0.7%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2a6d09...22bc90c. Read the comment docs.

@vthinkxie vthinkxie merged commit 6117f20 into NG-ZORRO:master Jul 22, 2018
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Jul 22, 2018
wenqi73 pushed a commit to wenqi73/ng-zorro-antd that referenced this pull request Aug 27, 2018
@hsuanxyz hsuanxyz deleted the tabs/fix-tab branch October 23, 2018 11:20
hsuanxyz added a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants