Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:pagination): fix nzPageIndexChange event does not emit #189

Merged
merged 1 commit into from
Aug 31, 2017

Conversation

SangKa
Copy link
Contributor

@SangKa SangKa commented Aug 30, 2017

Fix #171

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #171

What is the new behavior?

In the nzShowQuickJumper and nzSimple model, nzPageIndexChange event can emit as normal.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 40.346% when pulling 98f95da on SangKa:fix-171 into 29a5cbf on NG-ZORRO:master.

@vthinkxie vthinkxie merged commit 371b98a into NG-ZORRO:master Aug 31, 2017
@SangKa SangKa deleted the fix-171 branch February 10, 2018 13:39
@xiaodiao1212
Copy link

@vthinkxie hello, my br. When I use the paging component,the bug still exist!my [email protected]。Can you give me an explanation? I didn't find this fixed@171 when I checking the source code!

@vthinkxie
Copy link
Member

vthinkxie commented May 30, 2018

@xiaodiao1212 please provide repro link and submit a issue.
The pr is for 0.6.x version and all code are totally rewrite in 0.7.0.

@xiaodiao1212
Copy link

@vthinkxie You just using [email protected].

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

nzShowQuickJumper input does not emit nzPageIndexChange event while changing the value
4 participants