Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:select): fix input not blur after user hits enter key #1943

Merged
merged 1 commit into from
Aug 19, 2018

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Aug 8, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1940

What is the new behavior?

When users select and confirm selecting an option with arrow keys and enter key, the input element would blur.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Aug 8, 2018

Codecov Report

Merging #1943 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1943      +/-   ##
==========================================
+ Coverage   95.98%   95.99%   +<.01%     
==========================================
  Files         470      470              
  Lines       11393    11394       +1     
  Branches     1508     1508              
==========================================
+ Hits        10936    10938       +2     
  Misses        131      131              
+ Partials      326      325       -1
Impacted Files Coverage Δ
components/select/nz-select.component.ts 96.55% <100%> (+0.51%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30498c8...594d216. Read the comment docs.

@hsuanxyz hsuanxyz merged commit a64d04c into NG-ZORRO:master Aug 19, 2018
@wzhudev wzhudev deleted the fix-select branch August 20, 2018 11:21
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants