Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:steps): support customized starting index #2021

Merged
merged 1 commit into from
Sep 7, 2018

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Aug 21, 2018

close #1994

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1994

What is the new behavior?

Now user can specify the starting index.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@wzhudev wzhudev changed the title feat(module:steps): support custom starting index feat(module:steps): support costume starting index Aug 21, 2018
@wzhudev wzhudev changed the title feat(module:steps): support costume starting index feat(module:steps): support custom starting index Aug 21, 2018
@wzhudev wzhudev changed the title feat(module:steps): support custom starting index feat(module:steps): support customized starting index Aug 21, 2018
@codecov
Copy link

codecov bot commented Aug 21, 2018

Codecov Report

Merging #2021 into master will increase coverage by 0.05%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2021      +/-   ##
==========================================
+ Coverage   95.96%   96.01%   +0.05%     
==========================================
  Files         473      470       -3     
  Lines       11516    11429      -87     
  Branches     1535     1515      -20     
==========================================
- Hits        11051    10974      -77     
+ Misses        132      131       -1     
+ Partials      333      324       -9
Impacted Files Coverage Δ
components/steps/nz-steps.component.ts 98.52% <100%> (+0.11%) ⬆️
components/modal/nz-modal.component.ts 96.17% <0%> (-0.04%) ⬇️
components/pagination/nz-pagination.component.ts 99.29% <0%> (-0.01%) ⬇️
components/tree-select/nz-tree-select.component.ts 98.65% <0%> (-0.01%) ⬇️
components/button/nz-button.module.ts 100% <0%> (ø) ⬆️
components/button/nz-button.component.ts 100% <0%> (ø) ⬆️
components/modal/nz-modal-control.service.ts 100% <0%> (ø) ⬆️
components/switch/nz-switch.module.ts 100% <0%> (ø) ⬆️
components/core/wave/nz-wave.directive.ts
components/core/wave/nz-wave.module.ts
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cca1fdd...5afe15d. Read the comment docs.

@wzhudev
Copy link
Member Author

wzhudev commented Aug 21, 2018

We should merge this after Ant Design accepts a PR.

@wzhudev wzhudev changed the title feat(module:steps): support customized starting index [WIP] feat(module:steps): support customized starting index Aug 21, 2018
@wzhudev wzhudev changed the title [WIP] feat(module:steps): support customized starting index feat(module:steps): support customized starting index Sep 2, 2018
@simplejason simplejason merged commit bc7bf17 into NG-ZORRO:master Sep 7, 2018
hsuanxyz added a commit that referenced this pull request Sep 10, 2018
@wzhudev wzhudev deleted the step-index branch September 11, 2018 09:44
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

steps: add starting index
3 participants