feat(module:breadcrumb): support auto generated breadcrumbs #2050
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Test and live demo could be a problem. Working on it. |
Codecov Report
@@ Coverage Diff @@
## master #2050 +/- ##
==========================================
+ Coverage 95.96% 95.97% +0.01%
==========================================
Files 473 473
Lines 11516 11548 +32
Branches 1535 1540 +5
==========================================
+ Hits 11051 11083 +32
Misses 132 132
Partials 333 333
Continue to review full report at Codecov.
|
wzhudev
changed the title
wzhudev
force-pushed
the
breadcrumb
branch
4 times, most recently
from
0e0e379
to
0cd3e24
Compare
vthinkxie
reviewed
Sep 7, 2018
| <ng-container *ngIf="nzAutoGenerate"> | ||
| <nz-breadcrumb-item *ngFor="let breadcrumb of breadcrumbs"> | ||
| <a [href]="breadcrumb.url" (click)="navigateTo(breadcrumb.url, $event$event)">{{ breadcrumb.label }}</a> |
vthinkxie
requested changes
Sep 7, 2018
| <ng-container *ngIf="nzAutoGenerate"> | ||
| <nz-breadcrumb-item *ngFor="let breadcrumb of breadcrumbs"> | ||
| <a [href]="breadcrumb.url" (click)="navigateTo(breadcrumb.url, $event$event)">{{ breadcrumb.label }}</a> |
vthinkxie
approved these changes
Sep 7, 2018
|
Should change test when angular/angular#25837 is solved. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information