Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(module:table): improve table performance #2157

Merged
merged 1 commit into from
Sep 19, 2018
Merged

perf(module:table): improve table performance #2157

merged 1 commit into from
Sep 19, 2018

Conversation

vthinkxie
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[x] Other... Please describe: perf

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Sep 19, 2018

Codecov Report

Merging #2157 into master will decrease coverage by <.01%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2157      +/-   ##
==========================================
- Coverage   96.02%   96.01%   -0.01%     
==========================================
  Files         479      479              
  Lines       11689    11697       +8     
  Branches     1563     1564       +1     
==========================================
+ Hits        11224    11231       +7     
- Misses        131      132       +1     
  Partials      334      334
Impacted Files Coverage Δ
components/table/nz-table.component.ts 95.55% <94.44%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c70ff04...b791d05. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Sep 19, 2018

Codecov Report

Merging #2157 into master will decrease coverage by <.01%.
The diff coverage is 94.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2157      +/-   ##
==========================================
- Coverage   96.02%   96.01%   -0.01%     
==========================================
  Files         479      479              
  Lines       11689    11697       +8     
  Branches     1563     1564       +1     
==========================================
+ Hits        11224    11231       +7     
- Misses        131      132       +1     
  Partials      334      334
Impacted Files Coverage Δ
components/table/nz-table.component.ts 95.55% <94.44%> (-0.38%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c70ff04...b791d05. Read the comment docs.

@vthinkxie vthinkxie merged commit cde5fb0 into NG-ZORRO:master Sep 19, 2018
@vthinkxie
Copy link
Member Author

close #2127

@vthinkxie vthinkxie deleted the fix-table branch October 10, 2018 02:48
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant