Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:cascader): fix support to nzLabelProperty #2231

Merged
merged 1 commit into from
Oct 18, 2018

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Oct 1, 2018

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[x] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Lack of support to nzLabelProperty.

Issue Number: #2103

What is the new behavior?

Would search nzLabelProperty when it's specified.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Oct 1, 2018

Codecov Report

Merging #2231 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2231      +/-   ##
==========================================
+ Coverage   95.88%   95.92%   +0.03%     
==========================================
  Files         485      485              
  Lines       12182    12184       +2     
  Branches     1638     1639       +1     
==========================================
+ Hits        11681    11687       +6     
+ Misses        143      142       -1     
+ Partials      358      355       -3
Impacted Files Coverage Δ
components/cascader/nz-cascader.component.ts 96.74% <100%> (+0.18%) ⬆️
components/table/nz-table.component.ts 95.55% <0%> (+1.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c24c5f6...53574bf. Read the comment docs.

@wzhudev wzhudev force-pushed the cascader-label branch 3 times, most recently from d933b6b to 69fdc33 Compare October 4, 2018 04:55
@wzhudev wzhudev force-pushed the cascader-label branch 2 times, most recently from 80ed2b3 to 477da80 Compare October 12, 2018 02:44
@wzhudev wzhudev force-pushed the cascader-label branch 4 times, most recently from d9b83a8 to 9159cde Compare October 16, 2018 07:04
@vthinkxie vthinkxie merged commit 37523c8 into NG-ZORRO:master Oct 18, 2018
@wzhudev wzhudev deleted the cascader-label branch October 25, 2018 04:17
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants