-
Notifications
You must be signed in to change notification settings - Fork 3.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(module:statistic): add statistic and countdown component #2760
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2760 +/- ##
==========================================
- Coverage 97.39% 97.37% -0.03%
==========================================
Files 537 545 +8
Lines 11168 11260 +92
Branches 805 809 +4
==========================================
+ Hits 10877 10964 +87
- Misses 183 188 +5
Partials 108 108
Continue to review full report at Codecov.
|
Deploy preview for ng-zorro-master ready! Built with commit 26efa18 |
@hsuanxyz All fixed. Please review. |
@hsuanxyz Blocked by what? |
Since we are going to change date format string API, this PR should be ready to merge. |
66da4fd
to
0d4caa6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- remove [nzPrecision] [nzDecimalSeparator] [nzGroupSeparator]
- nz-countdown -> nzTimeRangePipe
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…RO#2760) * feat(module:statistic): add statistic and countdown component * fix: time range handle undefined value
…RO#2760) * feat(module:statistic): add statistic and countdown component * fix: time range handle undefined value
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: #2754
What is the new behavior?
Does this PR introduce a breaking change?
Other information