Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(module:calendar): sync some changes from ant-design (#2769) #2796

Closed
wants to merge 0 commits into from

Conversation

zhytang
Copy link
Contributor

@zhytang zhytang commented Jan 16, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #2769

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Jan 16, 2019

Deploy preview for ng-zorro-master ready!

Built with commit a67984c

https://deploy-preview-2796--ng-zorro-master.netlify.com

@codecov
Copy link

codecov bot commented Jan 16, 2019

Codecov Report

Merging #2796 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2796      +/-   ##
==========================================
- Coverage   97.36%   97.36%   -0.01%     
==========================================
  Files         526      526              
  Lines       11026    11032       +6     
  Branches      786      786              
==========================================
+ Hits        10736    10741       +5     
- Misses        189      190       +1     
  Partials      101      101
Impacted Files Coverage Δ
components/calendar/nz-calendar.component.ts 100% <100%> (ø) ⬆️
components/table/nz-table.component.ts 98.27% <0%> (-0.87%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a67984c...91a4faa. Read the comment docs.

@@ -466,3 +466,18 @@ class NzTestCalendarMonthCellComponent { }
`
})
class NzTestCalendarMonthFullCellComponent { }

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test needed

@zhytang
Copy link
Contributor Author

zhytang commented Feb 16, 2019

add test

@vthinkxie
Copy link
Member

Hi @zhytang
plz rebase your pr onto master, thanks a lot

@zhytang
Copy link
Contributor Author

zhytang commented Feb 24, 2019

Hi @zhytang
plz rebase your pr onto master, thanks a lot

Sorry, I have rebase, but there is a mistake, and a new pr (2963)

Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants