Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(module:empty): fix locale cannot change dynamically #2866

Merged
merged 2 commits into from
Feb 11, 2019

Conversation

wzhudev
Copy link
Member

@wzhudev wzhudev commented Feb 1, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Application (the showcase website) / infrastructure changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: N/A

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@codecov
Copy link

codecov bot commented Feb 1, 2019

Codecov Report

Merging #2866 into master will increase coverage by 0.02%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #2866      +/-   ##
=========================================
+ Coverage   95.47%   95.5%   +0.02%     
=========================================
  Files         521     521              
  Lines       12229   12247      +18     
  Branches     1671    1672       +1     
=========================================
+ Hits        11676   11696      +20     
+ Misses        199     198       -1     
+ Partials      354     353       -1
Impacted Files Coverage Δ
components/icon/nz-icon.service.ts 98.27% <ø> (ø) ⬆️
components/empty/nz-empty.component.ts 100% <100%> (ø) ⬆️
components/core/scroll/nz-scroll.service.ts 76.92% <0%> (+3.84%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1e081f0...0b2c7d2. Read the comment docs.

@netlify
Copy link

netlify bot commented Feb 1, 2019

Deploy preview for ng-zorro-master ready!

Built with commit 0b2c7d2

https://deploy-preview-2866--ng-zorro-master.netlify.com

@wzhudev wzhudev force-pushed the fix-empty-i18n branch 3 times, most recently from 092eeaf to 8d4cb7c Compare February 2, 2019 10:52
@wzhudev wzhudev force-pushed the fix-empty-i18n branch 2 times, most recently from 504ad7a to 38497ee Compare February 2, 2019 11:56
Copy link
Member

@vthinkxie vthinkxie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vthinkxie vthinkxie merged commit 2a2fbca into NG-ZORRO:master Feb 11, 2019
@wzhudev wzhudev deleted the fix-empty-i18n branch February 11, 2019 03:49
Ricbet pushed a commit to Ricbet/ng-zorro-antd that referenced this pull request Apr 9, 2020
* fix(module:empty): fix locale cannot change dynamically

* fix: test
hsuanxyz pushed a commit to hsuanxyz/ng-zorro-antd that referenced this pull request Aug 5, 2020
* fix(module:empty): fix locale cannot change dynamically

* fix: test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants