feat(module:icon): support rotate #2891
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for ng-zorro-master ready! Built with commit c56850d |
Codecov Report
@@ Coverage Diff @@
## master #2891 +/- ##
==========================================
- Coverage 97.38% 97.36% -0.02%
==========================================
Files 526 526
Lines 10964 11033 +69
Branches 787 786 -1
==========================================
+ Hits 10677 10742 +65
- Misses 184 190 +6
+ Partials 103 101 -2
Continue to review full report at Codecov.
|
vthinkxie
reviewed
Feb 14, 2019
| @@ -29,7 +29,9 @@ We are still adding two-tone icons right now, syncing to [antd](https://ant.desi | |||
| | `[spin]` | Rotate icon with animation | `boolean` | `false` | | |||
| | `[twoToneColor]` | Only support the two-tone icon. Specific the primary color. | `string (hex color)` | - | | |||
| | `[iconfont]` | Type of the icon from iconfont | `string` | - | | |||
| | `[nzRotate]` | Rotate degrees (since 7.0.0) | `number` | - | | |||
There was a problem hiding this comment.
en and zh doc are not the same
vthinkxie
reviewed
Feb 14, 2019
components/icon/demo/basic.ts
Outdated
| @@ -8,6 +8,7 @@ import { Component } from '@angular/core'; | |||
| <i nz-icon [type]="'setting'" [theme]="'fill'"></i> | |||
| <i nz-icon [type]="'smile'" [theme]="'outline'"></i> | |||
| <i nz-icon [type]="'sync'" [spin]="true"></i> | |||
| <i nz-icon [type]="'smile'" [theme]="'outline'" [nzRotate]="180"></i> | |||
|
@vthinkxie I've updated the API in docs, demos, and tests. Please review. |
vthinkxie
approved these changes
Feb 18, 2019
Ricbet
pushed a commit
to Ricbet/ng-zorro-antd
that referenced
this pull request
Apr 9, 2020
* feat(module:icon): support rotate close NG-ZORRO#2888 * fix: switch to API with prefix * docs: raname API in demo
hsuanxyz
pushed a commit
to hsuanxyz/ng-zorro-antd
that referenced
this pull request
Aug 5, 2020
* feat(module:icon): support rotate close NG-ZORRO#2888 * fix: switch to API with prefix * docs: raname API in demo
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
close #2888
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information